Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/Hide star count does not update immediately #8765

Open
2 tasks done
shamim-emon opened this issue Jan 22, 2025 · 1 comment
Open
2 tasks done

Show/Hide star count does not update immediately #8765

shamim-emon opened this issue Jan 22, 2025 · 1 comment
Labels
good first issue Ideal for newcomers to start contributing type: bug Something is causing incorrect behavior or errors

Comments

@shamim-emon
Copy link
Contributor

shamim-emon commented Jan 22, 2025

Checklist

  • I have used the search function to see if someone else has already submitted the same bug report.
  • I will describe the problem with as much detail as possible.

App

Thunderbird for Android

App version

10.0-SNAPSHOT

Where did you get the app from?

None

Android version

Android 12

Device model

No response

Steps to reproduce

  1. Open The Application.
  2. Click on Side Menu
  3. Click on Setting Gear at the bottom of menu
  4. Click on General Settings-> Display
  5. Scroll to Account List Section
  6. Toggle Show starred count
  7. Navigate back to Home screen
  8. In side menu change is not reflected.

If you close the app and open again, change is reflected.

Expected behavior

Toggle Show starred count should reflect immediately without re-starting the app.

Actual behavior

Toggle Show starred count does not reflect immediately without re-starting the app.

Logs

No response

@shamim-emon shamim-emon added type: bug Something is causing incorrect behavior or errors unconfirmed Newly reported issues awaiting triage or confirmation labels Jan 22, 2025
@wmontwe wmontwe added good first issue Ideal for newcomers to start contributing and removed unconfirmed Newly reported issues awaiting triage or confirmation labels Jan 23, 2025
@akash0228
Copy link

akash0228 commented Jan 30, 2025

Hi! @wmontwe I’ve been investigating the issue and here are my findings:

1.The value for show_starred_count (and other similar settings) is being updated directly via K9.isShowStarredCount in GeneralSettingsDataStore.
2.However, after the change, there doesn't seem to be any UI refresh or reactive update to reflect the change.

Before I proceed with the fix, I wanted to confirm the best approach:

1.Should I trigger a UI refresh after changing the setting (e.g., by using a StateFlow or other mechanisms to propagate the change)?
2.Or is there another approach you’d recommend to ensure the UI reflects the updated settings after they’ve been changed?

Any guidance would be really helpful before I start implementing the fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for newcomers to start contributing type: bug Something is causing incorrect behavior or errors
Projects
None yet
Development

No branches or pull requests

3 participants