Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport changes from retired 2.0 branch #1076

Open
3 of 8 tasks
yaxu opened this issue Apr 13, 2024 · 3 comments
Open
3 of 8 tasks

Backport changes from retired 2.0 branch #1076

yaxu opened this issue Apr 13, 2024 · 3 comments

Comments

@yaxu
Copy link
Member

yaxu commented Apr 13, 2024

The old 2.0-dev branch is now retired.

Some changes should be backported to the active dev branch.

PRs to look at:

cycseq things

  • 62c2eec
  • move base package to tidal-core, splitting out tidal-params-dirt and tidal-stream
@matthewkaney
Copy link
Contributor

#1081 addresses the Sound.Tidal.Boot changes and is ready for review. I've mostly got the handshake OSC changes ported too, but I want to add a couple tests and bug fixes to address #1030.

I'm also interested in taking a look at some of the package reorganization code, but can approach that more piecemeal.

@sss-create
Copy link

anything I can help with? How about the Megaparsec branch in ParseBP? I'm firm with hosc too. Or something basic so I can familiarize with the code base especially Patterns, ControlPatterns and how the cycling works.

@yaxu
Copy link
Member Author

yaxu commented Jan 10, 2025

Hi @sss-create ! As far as I remember, I didn't get far with megaparsec, and don't have a sense for the advantages of switching to it. Feel free to have a fresh look, but I'd assume that would involve starting afresh. We should probably continue discussion in a dedicated issue to it.

Otherwise from this task it looks like #1055 and #1012 still need merging into dev and are probably straightforward. I'm unsure about #1027, do you know @matthewkaney ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants