Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement iterator-based subset() #3072

Closed
krlmlr opened this issue Sep 3, 2017 · 2 comments
Closed

Implement iterator-based subset() #3072

krlmlr opened this issue Sep 3, 2017 · 2 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Sep 3, 2017

for e.g. slice() with negative indices: Currently, the entire list of positive indices is materialized, this makes e.g. slice(-1) unnecessarily slow.

@romainfrancois
Copy link
Member

I think this has been taken care of with the refactoring of slice as part of #3492.

@lock
Copy link

lock bot commented Nov 25, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Nov 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants