Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault when using rbind() to combine two rowwise data frames #7024

Closed
GBarnsley opened this issue May 13, 2024 · 3 comments
Closed

Segfault when using rbind() to combine two rowwise data frames #7024

GBarnsley opened this issue May 13, 2024 · 3 comments

Comments

@GBarnsley
Copy link

When I use rbind to combine two row-wise data frames I get a vec_slice or segfault caught error.

library(dplyr)
rw_df <- iris %>%
    rowwise()

df_2 <- rbind(rw_df, rw_df)

#do something that access the values of the data frame
filter(df_2, Species == "setosa")

I'm using R 4.3.2 on Fedora 39, this happens both on the latest CRAN version (1.1.4) and the current GitHub version of Dplyr (d698022)

@etiennebacher
Copy link

I can reproduce this segfault when rbind() is used. A workaround is to use bind_rows() instead:

library(dplyr, warn.conflicts = FALSE)
rw_df <- iris %>%
  rowwise()

df_2 <- bind_rows(rw_df, rw_df)

filter(df_2, Species == "setosa")
#> # A tibble: 100 × 5
#> # Rowwise: 
#>    Sepal.Length Sepal.Width Petal.Length Petal.Width Species
#>           <dbl>       <dbl>        <dbl>       <dbl> <fct>  
#>  1          5.1         3.5          1.4         0.2 setosa 
#>  2          4.9         3            1.4         0.2 setosa 
#>  3          4.7         3.2          1.3         0.2 setosa 
#>  4          4.6         3.1          1.5         0.2 setosa 
#>  5          5           3.6          1.4         0.2 setosa 
#>  6          5.4         3.9          1.7         0.4 setosa 
#>  7          4.6         3.4          1.4         0.3 setosa 
#>  8          5           3.4          1.5         0.2 setosa 
#>  9          4.4         2.9          1.4         0.2 setosa 
#> 10          4.9         3.1          1.5         0.1 setosa 
#> # ℹ 90 more rows

@DavisVaughan
Copy link
Member

Yea I can reproduce too, thanks, this is likely a vctrs issue so i will transfer there.

One thing to note is that the attributes on the result are definitely wrong (i.e. only shows 150 groups). There is a chance this may be an rbind() thing we can't work around, but not sure yet.

library(dplyr)

rw_df <- iris %>%
    rowwise()

df_2 <- rbind(rw_df, rw_df)

df_2
#> # A tibble: 300 × 5
#> # Rowwise: 
#>    Sepal.Length Sepal.Width Petal.Length Petal.Width Species
#>           <dbl>       <dbl>        <dbl>       <dbl> <fct>  
#>  1          5.1         3.5          1.4         0.2 setosa 
#>  2          4.9         3            1.4         0.2 setosa 
#>  3          4.7         3.2          1.3         0.2 setosa 
#>  4          4.6         3.1          1.5         0.2 setosa 
#>  5          5           3.6          1.4         0.2 setosa 
#>  6          5.4         3.9          1.7         0.4 setosa 
#>  7          4.6         3.4          1.4         0.3 setosa 
#>  8          5           3.4          1.5         0.2 setosa 
#>  9          4.4         2.9          1.4         0.2 setosa 
#> 10          4.9         3.1          1.5         0.1 setosa 
#> # ℹ 290 more rows

attributes(df_2)
#> $row.names
#>   [1]   1   2   3   4   5   6   7   8   9  10  11  12  13  14  15  16  17  18
#>  [19]  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36
#>  [37]  37  38  39  40  41  42  43  44  45  46  47  48  49  50  51  52  53  54
#>  [55]  55  56  57  58  59  60  61  62  63  64  65  66  67  68  69  70  71  72
#>  [73]  73  74  75  76  77  78  79  80  81  82  83  84  85  86  87  88  89  90
#>  [91]  91  92  93  94  95  96  97  98  99 100 101 102 103 104 105 106 107 108
#> [109] 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126
#> [127] 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144
#> [145] 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162
#> [163] 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180
#> [181] 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198
#> [199] 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216
#> [217] 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234
#> [235] 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252
#> [253] 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270
#> [271] 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288
#> [289] 289 290 291 292 293 294 295 296 297 298 299 300
#> 
#> $names
#> [1] "Sepal.Length" "Sepal.Width"  "Petal.Length" "Petal.Width"  "Species"     
#> 
#> $groups
#> # A tibble: 150 × 1
#>          .rows
#>    <list<int>>
#>  1         [1]
#>  2         [1]
#>  3         [1]
#>  4         [1]
#>  5         [1]
#>  6         [1]
#>  7         [1]
#>  8         [1]
#>  9         [1]
#> 10         [1]
#> # ℹ 140 more rows
#> 
#> $class
#> [1] "rowwise_df" "tbl_df"     "tbl"        "data.frame"

Created on 2024-05-14 with reprex v2.0.2

@DavisVaughan
Copy link
Member

Closing in favor of r-lib/vctrs#1935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants