Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fct_reorder() documentation problems #255

Closed
sgschreiber opened this issue Feb 29, 2020 · 0 comments
Closed

fct_reorder() documentation problems #255

sgschreiber opened this issue Feb 29, 2020 · 0 comments
Labels
Milestone

Comments

@sgschreiber
Copy link

I was experimenting with fct_reorder and when I checked the online documentation (https://forcats.tidyverse.org/reference/fct_reorder.html), there were some things I noted:

  1. In the examples section, the third "iris" boxplot is placed under the "ChickWeight" code. I wonder if this could be moved up to the other two iris plots. I have tried to figure out how to suggest this myself in the .R file for fct_reorder() but I wasn't sure how to do that. Any help on how to do that would be great!

  2. When I use the "copy code to clipboard" button in the examples section, it won't separate the code for the 3 iris boxplots, instead it pastes them as boxplot(stuff)boxplot(stuff)boxplot(stuff). Maybe this could be updated, too?

  3. Why is only the second plot in the "ChickWeight" examples plotted but the code for the first one is provided? I am assuming that is because the second plot actually demonstrates what fct_reorder2() does, while the code for the first plot is there so that if someone wants to plot it, they can do this quickly and compare with the second plot? Sorry if this is a silly question but I wasn't 100% sure why it is documented the way it is.

@hadley hadley added the help wanted ❤️ we'd love your help! label Mar 2, 2022
@hadley hadley added this to the v1.0.0 milestone Jan 3, 2023
@hadley hadley changed the title Documentation for fct_reorder fct_reorder() documentation problems Jan 3, 2023
@hadley hadley closed this as completed in 050a867 Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants