Is should-filter always return nil ?

[jadestrong]

company-lsp/company-lsp.el

Line 427 in f921ffa

(and (null company-lsp-cache-candidates)

null is a function defined in C source code.

Signature
(null OBJECT)

Documentation
Return t if OBJECT is nil, and return nil otherwise.

I think there should be if company-lsp-cache-candidates not nil, then get config from filter candidates , so the code should be:

(and (not (null company-lsp-cache-candidates))
                                 (company-lsp--get-config company-lsp-filter-candidates server-id))

[jadestrong]

company-lsp/company-lsp.el

Lines 432 to 438 in f921ffa

	(when (eq company-lsp-cache-candidates 'auto)
	;; Only cache candidates on auto mode. If it's t company caches the
	;; candidates for us.
	(company-lsp--cache-put prefix (company-lsp--cache-item-new candidates incomplete)))
	(if should-filter
	(company-lsp--filter-candidates candidates prefix)
	candidates)))

company-lsp/company-lsp.el

Lines 524 to 528 in f921ffa

	(cond
	((string= prefix subprefix)
	;; Found exact match.
	cache-item)
	((company-lsp--cache-item-incomplete-p cache-item)

Here also has an another problem, when should-filter is t, but company-lsp--cache-put only cached the unfiltered candidates.
Then company-lsp--cache-get will return the unfiltered candidates.

[jadestrong]

#141

[jadestrong]

Maybe we should filter cache-item in company-lsp--cache-get , not cache filtered candidates? Then we can reuse the candidates when there had a prefix closed to the cached prefix.