Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PD RPC client provides "output regions must have leader" guarantee option #8442

Open
lance6716 opened this issue Jul 26, 2024 · 0 comments
Open

PD RPC client provides "output regions must have leader" guarantee option #8442

lance6716 opened this issue Jul 26, 2024 · 0 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lance6716
Copy link
Contributor

Enhancement Task

Callers sometimes have their own logic to check the leader of regions from scan regions API

https://github.com/pingcap/tidb/blob/7e73ddc91b5f9f089e84f0dc645cf71a27b2ad50/br/pkg/restore/split/split.go#L72

https://github.com/tikv/client-go/blob/88ce38492f7b30d95f4e3a7c760ba44c9a32f1be/internal/locate/region_cache.go#L2328-L2339

I prefer the client can provide an option to handle it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lance6716