-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library does not properly decode dynamic segment from utf-8 route #145
Comments
@rwjblue No worries, thanks for the ping. I'll take a look at this and give some ideas. |
@estshy Can you give some more details to help reproduce the issue you're seeing?
This router snippet that you provided above doesn't have any dynamic segments. It instructs the router to recognize the static path "/praca-sprzątanie/kczewo". I created a second twiddle that has a dynamic segment for Let me know if I misunderstood the issue that you ran into. |
@bantic At the moment I am not able to reproduce the issue on twiddle and I am not sure why. I will get back to you with a failing test case when I will have more time to dig into it. For now I made workaround by extracting the missing parameter from url manually. |
When going on praca-sprzątanie/kczewo, route is properly recognized but dynamic segement is passed down as null. Code does behave correctly with
ENCODE_AND_DECODE_PATH_SEGMENTS
turned off.Problem comes down to fact that
originalPath
is not decoded anyhow but later on it's used inside regular expression.Is there any way to overwrite
ENCODE_AND_DECODE_PATH_SEGMENTS
flag from ember application till the issue will be resolved?Issue was observed on ember 3.4.0
The text was updated successfully, but these errors were encountered: