Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

water lines should be merged #1135

Closed
sensescape opened this issue Nov 22, 2016 · 5 comments
Closed

water lines should be merged #1135

sensescape opened this issue Nov 22, 2016 · 5 comments
Assignees
Milestone

Comments

@sensescape
Copy link

  • What did you see? Lots of tiny river segments at zoom 9
  • What did you expect to see? Smooth rivers
  • What map location are you having problems with? 9.0593/36.0268/-77.5754
  • Screenshot?

screen shot 2016-11-21 at 6 21 54 pm

@nvkelso nvkelso added this to the v1.6.0 milestone Sep 25, 2018
@rmarianski rmarianski self-assigned this Nov 6, 2018
@ghost ghost added the in review label Nov 8, 2018
@rmarianski
Copy link
Member

After merging, we realized some gains:

Overall:

.water.features 18870 -> 13482
.water.properties.size 2862 -> 2302
.water.properties.values.count 349 -> 269

Kind breakdown:

.water.features.canal.count 83 -> 5
.water.features.canal.geom_cmds 827 -> 487
.water.features.canal.metadata 332 -> 21
.water.features.canal.properties 1178 -> 70
.water.features.river.count 283 -> 149
.water.features.river.geom_cmds 2690 -> 1641
.water.features.river.metadata 1132 -> 597
.water.features.river.names.count 282 -> 148
.water.features.river.properties 4420 -> 2497
.water.features.riverbank.geom_cmds 4937 -> 4902
.water.features.riverbank.properties 277 -> 270

@rmarianski
Copy link
Member

Screenshots of the lines in the tile.

Before:

image

After:

image

@nvkelso
Copy link
Member

nvkelso commented Nov 8, 2018

See also:

@nvkelso
Copy link
Member

nvkelso commented Dec 13, 2018

For Tangram testing, from #358:

color: |  #Style.color.randomColor()
                   function() {
                       var letters = '0123456789ABCDEF';
                       var color = '#';
                       for (var i = 0; i < 6; i++ ) {
                           color += letters[Math.floor(Math.random() * 16)];
                       }
                       return color;
                   }

@nvkelso
Copy link
Member

nvkelso commented Dec 13, 2018

This is working...

New:

image

Old:

image

@nvkelso nvkelso closed this as completed Dec 13, 2018
@ghost ghost removed the send to staging label Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants