Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using tags-> in YAML #1199

Closed
zerebubuth opened this issue Apr 7, 2017 · 6 comments
Closed

Stop using tags-> in YAML #1199

zerebubuth opened this issue Apr 7, 2017 · 6 comments
Assignees
Milestone

Comments

@zerebubuth
Copy link
Member

Since we moved to the hstore schema, everything is in the tags column and the tags-> prefix is unnecessary. We've got a mix of different uses in the YAML files, but it could be confusing for any new contributors whether tags-> is required or not (just to be clear: it's not).

This should just be a sed 's/tags->//' on the YAML files, but it's possible that it might throw up some unexpected regressions.

@nvkelso
Copy link
Member

nvkelso commented Apr 7, 2017 via email

@nvkelso nvkelso added this to the v1.2.0 milestone Apr 7, 2017
@nvkelso
Copy link
Member

nvkelso commented Jun 27, 2017

@zerebubuth @rmarianski Does your RAWR tile refactor address this issue as process changed?

@nvkelso nvkelso modified the milestones: v1.4.0 RAWR, v1.5.0 Jun 27, 2017
@rmarianski
Copy link
Member

I think it's a good idea to fit into the rawr tiles work.

@rmarianski rmarianski self-assigned this Jun 28, 2017
@nvkelso
Copy link
Member

nvkelso commented Apr 30, 2018

There are still a few of these hanging out. Deferring to next milestone.

@nvkelso nvkelso modified the milestones: v1.4.0 RAWR, v1.6.0 Apr 30, 2018
@nvkelso nvkelso modified the milestones: v1.6.0, v1.7.0 Sep 25, 2018
@nvkelso nvkelso modified the milestones: v1.8.0, v1.7.0 Jan 7, 2019
@nvkelso
Copy link
Member

nvkelso commented Jan 7, 2019

Fixed by #1771.

@nvkelso
Copy link
Member

nvkelso commented Jan 23, 2019

QA verified.

@nvkelso nvkelso closed this as completed Jan 23, 2019
@ghost ghost removed the send to staging label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants