Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌍 Natural Earth earth features should have variable min_zoom #1287

Closed
1 of 2 tasks
nvkelso opened this issue Jun 28, 2017 · 3 comments
Closed
1 of 2 tasks

🌍 Natural Earth earth features should have variable min_zoom #1287

nvkelso opened this issue Jun 28, 2017 · 3 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Jun 28, 2017

tl;dr

  • Earth features still need variable min_zom
  • Water layer features received variable min_zoom in v1.6

===

@sensescape found this one in the Refill LOD sprint:

- filter: {featurecla: Lake}
    min_zoom: 0
    output: {kind: lake}
    table: ne

All these are seeing to min_zoom 0, but we should be sourcing from the scalerank (or future Natural Earth's min_zoom values directly in the future).

Check also earth values.

screen shot 2017-06-28 at 3 08 59 pm

screen shot 2017-06-28 at 3 09 08 pm

@nvkelso nvkelso added this to the v1.5.0 milestone Jun 28, 2017
@nvkelso nvkelso added the bug label Jun 28, 2017
@nvkelso
Copy link
Member Author

nvkelso commented Jun 28, 2017

Earth:

  - filter: {gid: true}
    min_zoom: 0
    output: {kind: earth}
    table: ne

@nvkelso nvkelso changed the title Natural Earth water features should have not 0 min_zoom 💬 Natural Earth water features should have not 0 min_zoom Jul 27, 2017
@nvkelso nvkelso changed the title 💬 Natural Earth water features should have not 0 min_zoom 🎈 Natural Earth water features should have not 0 min_zoom Jul 27, 2017
@nvkelso nvkelso changed the title 🎈 Natural Earth water features should have not 0 min_zoom 🌍 Natural Earth water features should have not 0 min_zoom Jul 27, 2017
@nvkelso nvkelso self-assigned this Nov 28, 2017
@nvkelso nvkelso changed the title 🌍 Natural Earth water features should have not 0 min_zoom 🌍 Natural Earth water and land features should have variable min_zoom Jun 5, 2018
@nvkelso nvkelso removed their assignment Jun 5, 2018
@nvkelso nvkelso modified the milestones: v1.5.0, v1.6.0 Jun 14, 2018
@nvkelso nvkelso modified the milestones: v1.6.0, v1.7.0 Nov 5, 2018
@nvkelso nvkelso modified the milestones: v1.8.0, v1.7.0 Jan 8, 2019
@nvkelso
Copy link
Member Author

nvkelso commented Jan 8, 2019

The water layer portion of this was fixed in #1714 for v1.6 milestone.

The earth portion remains (it's hard coded at 0 min_zoom always now for Natural Earth).

@nvkelso nvkelso modified the milestones: v1.7.0, v1.8.0 Jan 8, 2019
@nvkelso nvkelso changed the title 🌍 Natural Earth water and land features should have variable min_zoom 🌍 Natural Earth earth features should have variable min_zoom Feb 13, 2019
@nvkelso nvkelso modified the milestones: v1.9.0, v1.8.0 Feb 20, 2019
@nvkelso nvkelso added the polish label Mar 27, 2019
@ghost ghost assigned zerebubuth Mar 28, 2019
@ghost ghost added the in review label Mar 28, 2019
@nvkelso
Copy link
Member Author

nvkelso commented Apr 22, 2019

Verified.

image

image

image

@nvkelso nvkelso closed this as completed Apr 22, 2019
@ghost ghost removed the in review label Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants