Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junk healthcare values #1596

Closed
nvkelso opened this issue Sep 17, 2018 · 3 comments
Closed

Junk healthcare values #1596

nvkelso opened this issue Sep 17, 2018 · 3 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Sep 17, 2018

In the POIs YAML it looks like we have a bad copy-paste job for some values:

  • What did you see? - filter: {healthcare: [bank, blood, chiropractor, donation, hospice, midwife, midwife_occupational, optometrist_paediatrics, physiotherapist_physiotherapy, podiatrist_psychotherapist, rehabilitation, speech, therapist, therapist]}
  • What did you expect to see? Values that exist IRL and in https://taginfo.openstreetmap.org/keys/healthcare#values.
@nvkelso nvkelso added this to the v1.6.0 milestone Sep 17, 2018
@zerebubuth
Copy link
Member

Ooops! I guess we're not testing enough of those values. Should we treat this as a regression rather than leaving to 1.6?

@nvkelso
Copy link
Member Author

nvkelso commented Sep 18, 2018

@zerebubuth I think most of those are "new" in v1.5 so no?

These look like they're covered in other v1.5 filters:

  • filter: {healthcare: [blood_donation, blood_bank]}

The rest are only covered in this filter. In any event, not enough to hold up the release and we can sort it out in v1.6.

@nvkelso
Copy link
Member Author

nvkelso commented Jan 23, 2019

QA verified.

@nvkelso nvkelso closed this as completed Jan 23, 2019
@ghost ghost removed the in review label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants