-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not enough building merging & simplification #1686
Comments
Looks like the Mapzen house styles hide many buildings at zooms 13 and 14, indicating to me we can drop
|
Connects to #1689. |
zoom 13 Smattering of building removed (okay), much more merging (great!) SF: 13/37.7607/-122.4357 zoom 14 Tons of tiny building removed (sad but okay), much more merging (great!), tiny file size (great!) SF: 14/37.7822/-122.4300 zoom 15 All the tiny building kept (good), much more merging (great!), smaller file size (great!) SF: 15/37.7835/-122.4275 zoom 16 All the buildings, with their IDs (no merging, good), similar file size (okay, improve another day possibly thru geometry generalization) SF: 16/37.7796/-122.4229 Future self: All using this color lookup function:
|
A few comments: First: this change looks visually great for Bubble Wrap and hugely reduces file size. Huzzah! But there seem to be 2 issues:
To clarify, I think zoom 13 looks better in this new setup (dropping more buildings), but zoom 14 looks worse (drops slightly too many buildings). I've filed #1732 to dig into that, and we can close this original issue which is huge step forward :) |
Building heights and extra properties (e.g:
roof_shape
orroof_colour
) are preventing merging between buildings. For example, tile14/6066/9294
in the north-west of Sao Paulo:(Coloured uniquely by feature.) There is some merging going, but still leaving us with over 9,000 unique multipolygons. Partly, this is because we're not quantising height enough:
(There are 5,406 unique height values.) Even when we zoom out, and are quantising values (although not all?), there's still a lot of merging inhibited by neighbouring building heights differing by more than 5m.
It also looks like we're not quantising heights for buildings (should they be
building:part
s?) withmin_height
orlayer != 0
.Also, we have quite a lot of small courtyards within buildings which probably aren't visible at this zoom level.
Finally, in this zoomed-in block from the
13/3033/4647
tile, you can see there's not a lot of merging going on between building geometries (even if they might be merged into the same multipolygon feature), so we're wasting a lot of bytes to describe each individual polygon.In summary:
roof_material
, and quantize height more aggressively at lower zooms for smaller buildings.layer
ormin_height
.The text was updated successfully, but these errors were encountered: