Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fewer places at low zoom. #1687

Closed
zerebubuth opened this issue Oct 11, 2018 · 5 comments
Closed

Fewer places at low zoom. #1687

zerebubuth opened this issue Oct 11, 2018 · 5 comments
Assignees
Milestone

Comments

@zerebubuth
Copy link
Member

The 0/0/0 tile contains:

  • 91 countries,
  • 744 regions,
  • 25 localities.

We couldn't possibly render all of these in a single tile, so we should remove some of them. The properties on these features are the major contributor to size of tiles at zooms 3 and lower.

@zerebubuth zerebubuth added this to the v1.6.0 milestone Oct 11, 2018
@nvkelso
Copy link
Member

nvkelso commented Oct 11, 2018

From #1684:

Let's use the min_zoom on country, region, and locality features from Natural Earth to drop labels.

In particular country labels don't all need to be shown at low zooms, just a few handful. There's a label min_zoom separate from feature min_zoom for this.

@nvkelso
Copy link
Member

nvkelso commented Dec 13, 2018

For 1/41/-74...

New:

image

Old:

image

@nvkelso
Copy link
Member

nvkelso commented Dec 13, 2018

0/43/-73

For zoom 0 we're still including too many countries, I'll file followup issue. Seems like we're doing 512 min_zoom math instead of 256 math? Like at zoom 0 we should only see features with min_zoom < 1, but many 1.x graded features are included.

New:
image

Old:
image

image
`

Similarly, Poland is visible at zoom 2, but has min_zoom of 3:

image

@nvkelso
Copy link
Member

nvkelso commented Dec 13, 2018

Generally this is working to significantly reduce file size... but we're still over stuffed. Followup in #1729.

For zoom 0 we're still including too many countries. The same is true for zooms 1 and 2. Addressing this will have significant file size savings.

Seems like we're doing 512 min_zoom math instead of 256 math? Like at zoom 0 we should only see features with min_zoom < 1, but many 1.x graded features are included.

New:
image

Old:
image

image
`
Poland is included at zoom 2, but it's min_zoom is 3.

image

@nvkelso
Copy link
Member

nvkelso commented Dec 14, 2018

Closing in favor of tiny bit of followup in #1729.

@nvkelso nvkelso closed this as completed Dec 14, 2018
@ghost ghost removed the send to staging label Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants