Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default country labels to zoom 6 instead of 1 for no-NE matches #1826

Closed
nvkelso opened this issue Feb 7, 2019 · 1 comment
Closed

Default country labels to zoom 6 instead of 1 for no-NE matches #1826

nvkelso opened this issue Feb 7, 2019 · 1 comment
Assignees
@zerebubuth
Labels
layer-places send to staging
Milestone
v1.7.0

Comments

@nvkelso
Copy link
Member

nvkelso commented Feb 7, 2019

Baby steps towards #1815, by hiding the junk down to zoom 6 instead of defaulting to 1 when we can't find a match in Natural Earth.

In the image below Transnistria and Nagorno-Karabakh are more disputed territories than countries.

image
@nvkelso nvkelso added this to the v1.7.0 milestone Feb 7, 2019
@zerebubuth zerebubuth mentioned this issue Feb 7, 2019
Merged
@ghost ghost assigned zerebubuth Feb 7, 2019
@ghost ghost added the in review label Feb 7, 2019
@nvkelso
Copy link
Member Author

nvkelso commented Feb 14, 2019

This is working :)

image

image

image

@nvkelso nvkelso closed this as completed Feb 14, 2019
@ghost ghost removed the in review label Feb 14, 2019
@nvkelso nvkelso mentioned this issue Feb 19, 2019
Open
@zerebubuth zerebubuth mentioned this issue May 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zerebubuth zerebubuth

Labels
layer-places send to staging
Projects
None yet
Milestone
v1.7.0
Development

No branches or pull requests
2 participants
@zerebubuth @nvkelso