SQL to hide unwanted NE borders #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvkelso
changed the title
nvkelso
requested changes
Apr 26, 2022
for more information, see https://pre-commit.ci
… into junderwood/suppress_ne_disputes
nvkelso
reviewed
Apr 27, 2022
| -- Add Russian disputed view to Nagorno-Karabakh | ||
| ab_do_so_tr_ne_10m_admin_0_boundary_lines_land as ( | ||
| update ne_10m_admin_0_boundary_lines_land l set | ||
| fclass_ru = '' |
There was a problem hiding this comment.
Is the intent this is "default" which happens to be unrecognized?
There was a problem hiding this comment.
Do we want this to be unrecognized? I thought we wanted to show a disputed border there for russia to show that they acknowledge something existing, but not quite a country.
nvkelso
reviewed
Apr 27, 2022
| update ne_10m_admin_0_boundary_lines_land l set | ||
| fclass_tr = 'country' | ||
| where l.ne_id in ( | ||
| select ne_id from nagorno_karabakh |
There was a problem hiding this comment.
Is this for Northern Cyprus or nagorno_karabakh?
There was a problem hiding this comment.
Yeah good call. This isn't really ready for review yet. I'm just testing out the syntax
nvkelso
reviewed
Apr 27, 2022
data/perform-sql-updates.sh
Outdated
| @@ -43,6 +43,10 @@ echo "done." | |||
| echo -e "\nDeleting disputed names" | |||
| psql $PSQLOPTS $@ -f apply-planet_disputed_area_features_name_suppression.sql | |||
|
|
|||
| # Deletes some of the Natural Earth dispute borders that we do not want to render | |||
There was a problem hiding this comment.
This is no longer deleting, please update comment and echo
jeffdefacto
changed the title
tgrigsby-sc
approved these changes
Apr 27, 2022
added 3 commits
April 28, 2022 11:40
…causing the problem. Refactored to simpler queries that run individually.
nvkelso
reviewed
Apr 29, 2022
nvkelso
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes any NE border feature that matches with the list of ne_ids in the
remove_linestable.