Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip file opening, allow reading from csv string #120

Closed
waruboy opened this issue Feb 2, 2018 · 3 comments
Closed

Skip file opening, allow reading from csv string #120

waruboy opened this issue Feb 2, 2018 · 3 comments
Labels

Comments

@waruboy
Copy link

waruboy commented Feb 2, 2018

Hi Tilo! I'm reviewing the 2.0 version. Nice rewrite!

With the additional flexibility, I'm wondering if you can add support to just process a huge csv string.
Use case: We download our csv from amazon s3 and have it ready on memory. Would be nice if we can just feed it to smarterCSV ala CSV.parse()

@tilo
Copy link
Owner

tilo commented Feb 2, 2018

Thank you! I'll look into it.

@waruboy reading the whole file from S3 into memory doesn't seem like the most efficient way though.

it would probably better if you do something like this:
https://stackoverflow.com/questions/46126904/stream-a-large-file-line-by-line-from-s3

and then use SmarterCSV with processing in 'chunks'

One tricky thing is that there is no rewind.

@tilo tilo added the v2.0 label Feb 2, 2018
@waruboy
Copy link
Author

waruboy commented Feb 2, 2018

Ah, our csv is only in tens of MB, so it's too large to process in-request, but still ok for in-memory processing.
I agree that we might need to do streaming in the future though, so thanks for pointing me to the resource

@tilo
Copy link
Owner

tilo commented Mar 20, 2023

ear-marked for v2.0

@tilo tilo closed this as completed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants