Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack plugins/resolve not working with yarn workspace #618

Closed
tonisives opened this issue Apr 12, 2022 · 2 comments
Closed

webpack plugins/resolve not working with yarn workspace #618

tonisives opened this issue Apr 12, 2022 · 2 comments

Comments

@tonisives
Copy link

There's and issue with react-scripts 5 where some libraries require polyfills.

adding

  config.resolve.fallback = {
    ...config.resolve.fallback,
    stream: require.resolve("stream-browserify"),
    buffer: require.resolve("buffer"),
  }

works in a normal CRA, but not in yarn workspaces.

here is and issue about the missing polyfills.

Resolution

Yarn workspaces are supported in craco

@dawnmist
Copy link
Collaborator

What happens in a yarn workspaces project?
What are the actual errors received?
Does building complete but the bundle not contain the fallback polyfills, or does the build itself break?
Can you provide an example project showing the problem that I can use to investigate it?
What is your config-overrides that is failing to work?

The link you've provided shows what happens in a normal CRA project, but nothing about a workspaces project or how that acts differently.

@timarney
Copy link
Owner

timarney commented Jun 8, 2022

Closing this as there hasn't been any activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants