Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_eof function should check if socke is a reqeust socket. #9

Open
anyfeel opened this issue Apr 12, 2018 · 0 comments
Open

read_eof function should check if socke is a reqeust socket. #9

anyfeel opened this issue Apr 12, 2018 · 0 comments
Assignees

Comments

@anyfeel
Copy link

anyfeel commented Apr 12, 2018

should also check if sock is req-socket in read_eof function, for
get_body_reader will call read_eof function in line 720, and if state is read_eof, it will try to setkeepalive on a req-socket which is forbidden. the runtime error traceback like below:

2018/04/12 16:30:50 [error] 30699#0: *2621 lua entry thread aborted: runtime error: /home/vagrant/shanks/nginx//app/lib/resty/httpipe.lua:516: attempt to call method 'setkeepalive' (a nil value)
stack traceback:
coroutine 0:
        /home/vagrant/shanks/nginx//app/lib/resty/httpipe.lua: in function 'set_keepalive'
        /home/vagrant/shanks/nginx//app/lib/resty/httpipe.lua:549: in function 'read'
        /home/vagrant/shanks/nginx//app/lib/resty/httpipe.lua:730: in function 'reader'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant