Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~topical reviewers? #110

Open
abathur opened this issue Jan 16, 2021 · 1 comment
Open

~topical reviewers? #110

abathur opened this issue Jan 16, 2021 · 1 comment

Comments

@abathur
Copy link

abathur commented Jan 16, 2021

I saw someone in #nixos ask specifically for a reviewer comfortable with C, and it just made me wonder if the ability to summon another reviewer who knows more about a specific language or software stack would be a useful ability for marvin in the longer term.

I would guess it's actually a reviewer command, so that it's only used if it poses domain-specific questions that a general reviewer can't answer.

@timokau
Copy link
Owner

timokau commented Jan 21, 2021

Yes, I agree that it would be useful. We already use some teams for a similar purpose, but pinging one of those always notifies all members. Marvin could have a command that just pings one member of an expert team.

If we ignore rate limiting (or use some very simple approach without retry), that should be easy to implement. I will focus on the core functionality of marvin for now though. Progress is very slow right now, so don't hold your breath. It might take a long time, or it might never happen.

If you want to contribute, I'd gladly help you to get a working test setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants