Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle typos #31

Open
turion opened this issue Jun 30, 2020 · 1 comment
Open

How to handle typos #31

turion opened this issue Jun 30, 2020 · 1 comment

Comments

@turion
Copy link

turion commented Jun 30, 2020

When you mistype a /status something command and then edit the comment to correct it, this change is not picked up by marvin.

@timokau
Copy link
Owner

timokau commented Jun 30, 2020

Yes, handling edits right is not easy. We'd want to avoid /status something in an old comment to be re-executed if you fix some unrelated typo. That would require parsing the diff, and even then it would probably no be easy to cover all the edge cases. Therefore I opted not to handle edits for now.

For what its worth, #29 will reduce the amount of explicit status commands you have to type a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants