-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading toast is removed before resolving the promise. #45
Loading toast is removed before resolving the promise. #45
Comments
@timolins any updates on this? |
Thanks for mentioning this. This is somewhat intended, I figured that I limit loading toasts to 30s to prevent them from getting stuck: https://github.com/timolins/react-hot-toast/blob/main/src/core/store.ts#L134 Looking back, it probably wasn't the best decision. I will change this to |
Yeah, I guess that's it. Thanks a lot, Timo! |
I noticed it's still not merged, any updates @timolins ? |
Yep, sorry for the delay. Currently planing out v1.1 which includes quite a few things I want to get right. I'll hope to release in the next couple of days. |
Sure and thanks. |
Any updates on this? @timolins |
I noticed a weird behavior when running a promise that takes fairly long (about 30s) the loading toast is automatically dismissed even before resolving the promise, when it's resolved the success toast appears.
Can you reproduce this? Try having a promise that takes about 30 or 40 seconds to execute.
Thanks Timo for this awesome library!
The text was updated successfully, but these errors were encountered: