Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required controlPlaneEndpoint field to cluster spec #14

Closed
invidian opened this issue Dec 14, 2020 · 3 comments · Fixed by #32
Closed

Add required controlPlaneEndpoint field to cluster spec #14

invidian opened this issue Dec 14, 2020 · 3 comments · Fixed by #32
Assignees
@invidian
Milestone
v0.1.0

Comments

@invidian
Copy link
Contributor

https://cluster-api.sigs.k8s.io/developer/architecture/controllers/cluster.html says it must be there and we don't have it, so we need to add it. And later on make sure cluster controller sets it to the right value.
@invidian invidian added this to the v0.1.0 milestone Dec 16, 2020
@cpanato
Copy link
Contributor

cpanato commented Dec 20, 2020

/assign

@invidian invidian mentioned this issue Dec 21, 2020
Closed
@invidian
Copy link
Contributor Author

This is actually done in #17.

@invidian invidian self-assigned this Dec 21, 2020
@cpanato
Copy link
Contributor

cpanato commented Dec 21, 2020

cool thanks @invidian

@detiber detiber mentioned this issue Feb 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@invidian invidian

Labels
None yet
Projects
None yet
Milestone
v0.1.0
2 participants
@cpanato @invidian