Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly declare or revert BuildKit dependency #196

Closed
chrisdoherty4 opened this issue Nov 22, 2022 · 0 comments · Fixed by #285
Closed

Explicitly declare or revert BuildKit dependency #196

chrisdoherty4 opened this issue Nov 22, 2022 · 0 comments · Fixed by #285

Comments

@chrisdoherty4
Copy link
Member

In #193 we found that BuildKit is required (#193 (comment)). We don't explicitly document this anywhere which is confusing for maintainers.

TL;DR our Dockerfile requires some built-in build args such as TARGETOS that are populated only when using BuildKit. See https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope for more details.

We need to either document the requirement or ensure these variables are manually populated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant