Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a GitHub Action workflow that validate Terraform Setup guide #8

Closed
gianarb opened this issue Sep 2, 2020 · 5 comments · Fixed by #179
Closed

Create a GitHub Action workflow that validate Terraform Setup guide #8

gianarb opened this issue Sep 2, 2020 · 5 comments · Fixed by #179
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v0.1.0

Comments

@gianarb
Copy link
Contributor

gianarb commented Sep 2, 2020 •
edited
Loading

Create a similar test suite as the one we use to validate Vagrant but for Terraform on Equinix Metal
@gianarb gianarb added this to the v0.1.0 milestone Sep 2, 2020
@gianarb
Copy link
Contributor Author

gianarb commented Sep 2, 2020

We can't do until #1 is over

@invidian
Copy link

invidian commented Jan 15, 2021 •
edited
Loading

#1 is now done, so this can be closed too? I see https://github.com/tinkerbell/sandbox/runs/1662739685?check_suite_focus=true being run.

With that, v0.1.0 milestone can be closed as well.

@gianarb
Copy link
Contributor Author

gianarb commented Jan 15, 2021

This issue to be closed requires a GitHub Action pipeline that validate that the Terrafrom Setup guide works. It is not done yet :( let me change the title

@gianarb gianarb changed the title Create GH workflow that validate terraform setup Create a GitHub Action workflow that validate Terraform Setup guide Jan 15, 2021
@invidian
Copy link

Ah, my bad. We only have a Vagrant check. Sorry for the noise :)

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Aug 27, 2021
@tstromberg
Copy link
Contributor

I think this sounds like a useful request to prevent future breakage. Any volunteers?

@tstromberg tstromberg added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 27, 2021
@jacobweinstock jacobweinstock mentioned this issue Oct 31, 2023
Merged
3 tasks
@mergify mergify bot closed this as completed in #179 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Remove unsupported deployment options jacobweinstock/playground
3 participants
@tstromberg @gianarb @invidian