Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a template does not update the workflows associated with that template #292

Closed
detiber opened this issue Sep 15, 2020 · 2 comments

Comments

@detiber
Copy link
Contributor

detiber commented Sep 15, 2020

Expected Behaviour

Updating a template should update existing workflows associated with that template

Current Behaviour

Updating a template does not affect existing workflows associated with that template

Steps to Reproduce (for bugs)

  1. Create an empty template (can be accomplished by Creating a template from a missing file succeeds when it shouldn't #291)
  2. Create a workflow associated with the previously created template
  3. Attempt to boot hardware that is associated with the workflow created above
  4. When the expected jobs fail to run, update the template to a proper template
  5. Reboot the hardware that is associated with the workflow, and it will fail to run jobs again.

Context

I mistakenly created an empty template by specifying the wrong file name and since it completed successfully, I created a workflow based on the empty template. I then attempted to boot hardware into the workflow and was confused as to why the configured jobs had failed to run. Once I realized the error, I attempted to update the template and expected that to affect the workflow that had not yet been run.

@gianarb
Copy link
Contributor

gianarb commented Sep 16, 2020

I have a couple of questions because I think I am reading this lifecycle in a different way:

In which state is the workflow at the end of point (4)? Is it in a failed state? And how do you know that?

@mmlb
Copy link
Contributor

mmlb commented Oct 13, 2020

Closing as not a bug. This is a missing docs bug and I've opened up tinkerbell/tinkerbell-docs#21 to address there.

@mmlb mmlb closed this as completed Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants