Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tink worker should never exit #463

Closed
mmlb opened this issue Mar 17, 2021 · 2 comments · Fixed by #655
Closed

Tink worker should never exit #463

mmlb opened this issue Mar 17, 2021 · 2 comments · Fixed by #655
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@mmlb
Copy link
Contributor

mmlb commented Mar 17, 2021

Tink worker should pass on any errors back to tink server but remain up. Otherwise the machine needs to be rebooted in order to get tink worker back up and running and ready to process more workflows. This seems unnecessary just to deal with an error, imagine if init did the same ;).

Expected Behaviour

Tink worker reports back errors but continues to stay up and connected to tink server.

Current Behaviour

Tink worker exits and we need to reboot or log in and restart tink-worker to get into a workflow processing state again.
@mmlb mmlb mentioned this issue Mar 17, 2021
Merged
@gianarb
Copy link
Contributor

gianarb commented Mar 18, 2021 •
edited
Loading

This is a duplicate of this #458 (comment) but it is written in a better form! So I will close the old one in favor of this!

@mmlb mmlb added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 18, 2021
@tstromberg tstromberg added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Aug 27, 2021
@jacobweinstock
Copy link
Member

jacobweinstock commented Dec 23, 2022 •
edited
Loading

Tink worker should be in a better position with #655, i believe there is still lots of room for improvement though and we have a roadmap item to refactor tink-worker entirely.

@jacobweinstock jacobweinstock mentioned this issue Dec 23, 2022
Merged
3 tasks
@mergify mergify bot closed this as completed in #655 Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up tink worker; remove os.Exit; ensure valid container names: jacobweinstock/tink
4 participants
@tstromberg @mmlb @gianarb @jacobweinstock