Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tink-worker: error logged without actionStatus #502

Closed
rgl opened this issue May 23, 2021 · 2 comments
Closed

tink-worker: error logged without actionStatus #502

rgl opened this issue May 23, 2021 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@rgl
Copy link
Contributor

rgl commented May 23, 2021

The following tink-worker error is logged without actionStatus:

l.With("actionStatus", actionStatus.ActionStatus.String())
l.Error(err)

Maybe this needs to be changed to:

l.With("actionStatus", actionStatus.ActionStatus.String()).Error(err) 

Or to also pass l context to exitWithGrpcError, this needs to be changed to:

l := l.With("actionStatus", actionStatus.ActionStatus.String())
l.Error(err) 
@displague
Copy link
Member

I've opened a PR with a fix for this (#517). I chose the l = l.With approach because l is passed into another function in a conditional branch.

Thanks for opening the issue and identifying the fixes!

@displague displague added the kind/bug Categorizes issue or PR as related to a bug. label Aug 10, 2021
@tstromberg tstromberg added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Aug 27, 2021
@mmlb
Copy link
Contributor

mmlb commented Feb 8, 2022

#517 is merged, this should have been closed then.

@mmlb mmlb closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

4 participants