Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tink fails to install because cfssl is no longer in the alpine linux testing repository #506

Closed
rgl opened this issue Jun 12, 2021 · 6 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@rgl
Copy link
Contributor

rgl commented Jun 12, 2021

Expected Behaviour

I should be able to install tink.

Current Behaviour

While tink is installing, it uses:

docker build --tag tinkerbell-certs /root/tink/deploy/tls

But that fails with the error:

Step 4/5 : RUN apk add --no-cache --update --upgrade --repository=http://dl-cdn.alpinelinux.org/alpine/edge/testing cfssl
 ---> Running in 7bfb4a37c1e8
fetch http://dl-cdn.alpinelinux.org/alpine/edge/testing/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/community/x86_64/APKINDEX.tar.gz
ERROR: unable to select packages:
  cfssl (no such package):
    required by: world[cfssl]
The command '/bin/sh -c apk add --no-cache --update --upgrade --repository=http://dl-cdn.alpinelinux.org/alpine/edge/testing cfssl' returned a non-zero code: 1

The cfssl is not longer in the alpine repository due to:

https://gitlab.alpinelinux.org/alpine/aports/-/commit/87380093c842e135ad4babaaca855f7abb2822cd
https://gitlab.alpinelinux.org/alpine/aports/-/commit/95690efbac51233c4255d0c33b706b70a9b02e1e
https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/testing/cfssl/APKBUILD

It seems that cfssl no longer builds in alpine (maybe because they started using go 1.16.5; see the second commit from above), so they disabled it.

@rgl
Copy link
Contributor Author

rgl commented Jun 12, 2021

@rgl
Copy link
Contributor Author

rgl commented Jun 13, 2021

https://gitlab.alpinelinux.org/alpine/aports/-/issues/12750 is now closed and there's an updated cfssl (from 1.5 to 1.6) at https://pkgs.alpinelinux.org/packages?name=cfssl&branch=edge

we should stop depending on the alpine edge branch and either help move cfssl to a proper alpine release or replace cfssl with openssl.

@nshalman
Copy link
Member

Thanks for the report! Do we need to discuss which branch of alpine we should switch to using?

@rgl
Copy link
Contributor Author

rgl commented Aug 10, 2021

At the time there was some discussion about this in the Tinkerbell slack. But I don't remember whether someone from Tinkerbell side was going to follow up on pushing cfssl to a future Alpine release (or whether that will happen "automatically" from testing to, say, v3.15).

I would prefer to use a stable branch, because that probably has a better chance of working the next time someone tries Tinkerbell.

@tstromberg tstromberg added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 27, 2021
@jacobweinstock
Copy link
Member

I'm curious if anyone knows why we need cfssl at all here:

apk add --repository=http://dl-cdn.alpinelinux.org/alpine/edge/testing cfssl
?

I personally don't know of any reason that is needed there. TLS certificates are generated via the docker-compose at the top level of the repo.

@mmlb
Copy link
Contributor

mmlb commented Apr 18, 2022

I'm curious if anyone knows why we need cfssl at all here:

apk add --repository=http://dl-cdn.alpinelinux.org/alpine/edge/testing cfssl

?

I personally don't know of any reason that is needed there. TLS certificates are generated via the docker-compose at the top level of the repo.

You are correct in that this hasn't been needed for a long time (see #584 (comment)). Its gone now though via #584.

@mmlb mmlb closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

5 participants