Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell is trying to fix checksums in go.mod #529

Closed
tstromberg opened this issue Sep 1, 2021 · 0 comments · Fixed by #530
Closed

codespell is trying to fix checksums in go.mod #529

tstromberg opened this issue Sep 1, 2021 · 0 comments · Fixed by #530

Comments

@tstromberg
Copy link
Contributor

From https://github.com/tinkerbell/tink/pull/514/checks?check_run_id=3484813791

+ xargs codespell -q 3 -I .codespell-whitelist
+ git ls-files
go.sum:1420: Od ==> Of
+ failed=1
+ git ls-files '*.yml' '*.json' '*.md'
+ xargs prettier --check
Checking formatting...
All matched files use Prettier code style!
+ git ls-files '*.sh'
+ xargs shfmt -l -d
+ git ls-files '*.sh'
+ xargs shellcheck
+ nixfmt shell.nix
+ git diff
+ grep .
+ exit 1

We should either exclude go.mod or replace this check with the built-in golangci-lint equivalent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant