Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tink server panic: The unary server interceptor was already set and may not be reset. #535

Closed
jacobweinstock opened this issue Sep 3, 2021 · 0 comments · Fixed by #536
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@jacobweinstock
Copy link
Member

jacobweinstock commented Sep 3, 2021

It appears that the introduction of the otel interceptors has caused a runtime panic.
tink/grpc-server/grpc_server.go:57-58

grpc.UnaryInterceptor(otelgrpc.UnaryServerInterceptor()),
grpc.StreamInterceptor(otelgrpc.StreamServerInterceptor()),

stack trace:

panic: The unary server interceptor was already set and may not be reset.

goroutine 1 [running]:
google.golang.org/grpc.UnaryInterceptor.func1(0xc00048e000)
        /Users/.../go/pkg/mod/google.golang.org/[email protected]/server.go:382 +0x6b
google.golang.org/grpc.(*funcServerOption).apply(0xc0000ba200, 0xc00048e000)
        /Users/.../go/pkg/mod/google.golang.org/[email protected]/server.go:201 +0x33
google.golang.org/grpc.NewServer(0xc000592280, 0x5, 0x8, 0x4)
        /Users/.../go/pkg/mod/google.golang.org/[email protected]/server.go:564 +0xeb
github.com/tinkerbell/tink/grpc-server.SetupGRPC(0xe209b0, 0xc00064a840, 0xd21547, 0x1a, 0xc000012010, 0xc000568150, 0xc00064aac0, 0xc00006ca20, 0x0, 0x0, ...)
        /Users/.../repos/tinkerbell/tink/grpc-server/grpc_server.go:77 +0x319
main.NewRootCommand.func2(0xc0003f0000, 0x12f82f8, 0x0, 0x0, 0x0, 0x0)
        /Users/.../repos/tinkerbell/tink/cmd/tink-server/main.go:183 +0x812
github.com/spf13/cobra.(*Command).execute(0xc0003f0000, 0xc00009e200, 0x0, 0x0, 0xc0003f0000, 0xc00009e200)
        /Users/.../go/pkg/mod/github.com/spf13/[email protected]/command.go:856 +0x472
github.com/spf13/cobra.(*Command).ExecuteC(0xc0003f0000, 0xd21547, 0x1a, 0xc000012010)
        /Users/.../go/pkg/mod/github.com/spf13/[email protected]/command.go:974 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
        /Users/.../go/pkg/mod/github.com/spf13/[email protected]/command.go:902
github.com/spf13/cobra.(*Command).ExecuteContext(...)
        /Users/.../go/pkg/mod/github.com/spf13/[email protected]/command.go:895
main.main()
        /Users/.../repos/tinkerbell/tink/cmd/tink-server/main.go:113 +0x1be

Expected Behaviour

Current Behaviour

Possible Solution

Steps to Reproduce (for bugs)

  1. make run
  2. docker logs tink_tinkerbell_1

Context

Your Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):

  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

  • Link to your project or a code example to reproduce issue:

@jacobweinstock jacobweinstock added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant