Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tink hardware push returns no useful data #89

Closed
alexellis opened this issue Apr 30, 2020 · 0 comments · Fixed by #92
Closed

tink hardware push returns no useful data #89

alexellis opened this issue Apr 30, 2020 · 0 comments · Fixed by #92
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@alexellis
Copy link
Contributor

tink hardware push returns no useful data - surely we can output something like "Inserted..OK", or some other data for users? The exit code can be checked, but is confusing.

tink hardware push "`cat /tmp/hardware.json`"
echo $?
0

Also can stdin be used to pipe the file or not?

cat /tmp/hardware.json | tink hardware push

This is unclear, but should be a workflow, putting the string in via args is not UNIX-like.

cc @gauravgahlot

@gauravgahlot gauravgahlot linked a pull request May 4, 2020 that will close this issue
@gauravgahlot gauravgahlot added the kind/feature Categorizes issue or PR as related to a new feature. label May 4, 2020
@gauravgahlot gauravgahlot self-assigned this May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants