Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Pandora #340

Open
juanrubio opened this issue Jun 26, 2017 · 4 comments
Open

Add support for Pandora #340

juanrubio opened this issue Jun 26, 2017 · 4 comments

Comments

@juanrubio
Copy link
Member

juanrubio commented Jun 26, 2017

There seems to be good Python support for Pandora's API

https://pypi.python.org/pypi/pydora/1.9.0

@juanrubio juanrubio added this to the v0.9.0 milestone Jun 26, 2017
@juanrubio juanrubio modified the milestones: v0.10.0, v0.9.0 Aug 28, 2017
@juanrubio juanrubio modified the milestones: v0.10.0, v0.11.0 Oct 21, 2017
@tizonia tizonia modified the milestones: v0.11.0, v0.13.0 Feb 11, 2018
@tizonia tizonia modified the milestones: v0.13.0, v0.14.0 Mar 14, 2018
@tizonia tizonia modified the milestones: v0.14.0, v0.15.0 Apr 18, 2018
@tizonia tizonia modified the milestones: v0.15.0, v0.16.0 Jun 15, 2018
@tizonia tizonia removed this from the v0.16.0 milestone Dec 20, 2018
@tcaddy
Copy link

tcaddy commented Dec 11, 2019

You might get somewhere by checking out PianoBar, which is an existing CLI Pandora client: https://github.com/PromyLOPh/pianobar

@tizonia
Copy link
Collaborator

tizonia commented Dec 11, 2019

@tcaddy

Thanks, I believe pianobar uses its own internal library:
https://github.com/PromyLOPh/pianobar/tree/master/src/libpiano
https://packages.debian.org/jessie/libpiano-dev

but the last time I checked, it looked quite cumbersome to use. I think Pydora looked much more straightforward.

The problem with Pandora's support in Tizonia is actually none of this. I've got a proof of concept implementation based on pydora that works. But the problem for Tizonia is the implementation of a mp4 demuxer OpenMAX IL component (Pandora delivers 'aacplus' in Mp4 containers).

That mp4 demuxer component needs to implement two roles:

  • one for demuxing from file: container_demuxer.source.mp4
  • another for demuxing from stream: container_demuxer.filter.mp4

The only standalone library that I could find that can do mp4 demuxing is MP4v2. But this is semi-abandoned. And it has no API for demuxing from a buffer (i.e. from stream). Only to demux from a file. So the Tizonia mp4 demuxer component would have to buffer the data into a temporary file or some sort of hack like that. Which seems to much hassle.

Unless I can find another solution to solves this problem (maybe libpiano! :-) )

@tizonia tizonia removed their assignment Apr 29, 2020
@SolarAquarion
Copy link
Contributor

https://github.com/lieff/minimp4 how about this muxer/demuxer

@juanrubio
Copy link
Member Author

@SolarAquarion

I think minimp4 looks interesting. I would need some time to test it. I can't really give an estimate of when I would get around to doing it, but it has piqued my interest!

Thanks for bringing it to my attention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants