Fix menu selection when installed version not present #541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template:
Describe what you did
Fixed menu selection when active node version is not present in list. (#292 #367 #400)
Removing prior work-around in PR #296 which blocked calling
n rm
on the active version, but that causes some confusion when people trying to uninstall. (#169 #327 #441)How you did it
Added speech marks around variable dereference in prev/next called when moving menu selection up or down.
Deleted now unnecessary lines of code blocking removal of current version.
How to verify it doesn't effect the functionality of n
Code inspection (simple changes).
Verify menu selection still works using
n
.Remove a cached version using
n rm <version>
.If this solves an issue, please put issue in PR notes.
Solves #292 #367 #391 #400
If this solves an issue, please include the output of issue that had problems and then the fixed output from the same command.
Menu selection works in this situation after fix. Hitting the up/down arrow from first display moves selected item to top/bottom version, with no error message displayed.
Squash any unnecessary commits to keep history clean as possible
Place description for the changelog in PR so we can tally all changes for any future release
Fix menu selection of cached node versions when active node version is not present in cache. Allow removal of active node version from cache.