Filter props on composed components #236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Filter props on components that are styled components that have string tags. For example the props on
Link
will now be filtered.Why:
Because otherwise there will be unknown prop warnings on composed styled components.
How:
Move the declaration of
spec
to be beforeStyled
is defined and check wether the first spec's tag is a string instead of just the tag.Checklist:
This is also a bit smaller now. 🎉