-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rome does not recognize last entry in Cartfile.resolved if there's no new line at end #165
Comments
Thanks for reporting, I will investigate. Edit: so here we're talking about a missing https://www.fileformat.info/info/unicode/char/000a/index.htm or missing http://www.fileformat.info/info/unicode/char/000d/index.htm at the end of last line |
@jbuckner Please try: https://github.com/blender/Rome/releases/tag/v0.18.2.54 and let me know if it solves your issue. This is a high risk change since I had to almost completely redo the parsing of the |
@blender Thank you for jumping on this so quickly! I tested |
@jbuckner released in https://github.com/blender/Rome/releases/tag/v0.19.0.55 I bumped the version number because of the new parser. Are you using this project privately or for work? |
Enhancement Suggestion / Bug Report
If there's no new line at the end of the last entry of
Cartfile.resolved
, Rome does not detect it as a dependency and doesn't upload or download it.Steps which explain the enhancement or reproduce the bug
Cartfile.resolved
so it ends at the last character of the last entry.rome upload
orrome download
Current behavior
Rome
does not recognize the last entry inCartfile.resolved
and doesn't upload or download it. It doesn't throw any errors, just silently skips it.Suggested behavior
Rome
should recognize this last dependencyWhy would the enhancement be useful to most users
This failure is silent and there's no indication that it has failed unless you look through the upload/download logs for the missing dependency.
Rome version:
OS and version:
The text was updated successfully, but these errors were encountered: