Rome fails with binary references in Cartfile.resolved, still exits cleanly

[erichoracek]

When the Cartfile.resolved contains a binary framework, e.g.:

binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" "3.5.0"

Rome emits the following error when attempting to perform a download:

$ rome download
Carfile.resolved parse error: "Cartfile.resolved" (line 1, column 1):
unexpected "b"
expecting white space, "git" or "github"

Additionally, when this occurs, Rome does not error with a non-zero exit status to indicate that an error occurred. This causes scripts to continue as if no error occurred.

This was tested with the latest Rome version:

$ rome --version              
0.10.1.22 - Romam uno die non fuisse conditam.

[tmspzz]

@erichoracek binary repos are not supported at the moment. I was unaware of this feature in Carthage.

I will add support for binary only frameworks, I need to study a little how deal with this case.

I'll also correct the exit status on parse errors.

[erichoracek]

Is there any reason why Rome would need to cache prebuilt frameworks for binary Cartfile references? Since these have no artifacts that need caching, I'd be fine if Rome just ignored them outright.

[tmspzz]

I guess a few reasons could be:

• to avoid a download if are using the local cache option.
• to store frameworks privately in your S3 bucket.

I can start with trying to tolerate parse errors in the Cartfile.resolved

[erichoracek]

Carthage has an internal cache for prebuilt binaries at:

~/Library/Caches/org.carthage.CarthageKit/binaries/

so I don't think that you'd be avoiding unnecessary downloads.

As such, as far as I can tell, the only benefit that Rome support for binary Cartfile references would have is storing binary frameworks in your S3 bucket.

The ideal behavior for us would just be to ignore these frameworks outright since we don't care about having these frameworks stored in our bucket. However, I can see how that may be unexpected behavior for some users.

[tmspzz]

I think a download can be avoided if the frameworks is placed directly at the correct path in Carthage/Build/{platform} and carthage just invoked with build

To make this work properly I think that Rome would need to resolve the binary json and figure out a couple of things. After that it would generate a Romefile.resolved (the irony) where it stores the missing information for these cases.

Immediate plan:

• Start simple and make the parsing fault tolerant (thus ignoring binary lines)

Further enhancement:

• try the resolved path

[erichoracek]

That seems reasonable—as long as binary lines are ignored for the time being and do not cause the command to fail that should work for us. 👍

[tmspzz]

Please try pre-release https://github.com/blender/Rome/releases/tag/v0.10.2.23

[erichoracek]

@blender that fixed it, thanks!

[tmspzz]

There is a full new release that includes this fix and #57 , get it with brew upgrade rome