Romefile RepositoryMap does not work with github references

[erichoracek]

It would appear that the Romefile repository map doesn't work with github references—only with git references. It seems to have to do with the deriveFrameworkName function at https://github.com/blender/Rome/blob/master/src/Lib.hs#L192, which doesn't appear to be using the romeMap to do a repo to framework lookup. This results in the Romefile mappings being unused when they are mapping from a github repo name to a framework name.

[tmspzz]

To clarify, I understand that your scenario is as follows:

In your Cartfile.resolved:

github "myAnimalStartup/Awesome-cat-names" "3.4.1"

But your framework name is actually not Awesome-cat-names but something else.

Correct?

[tmspzz]

Please try pre-release https://github.com/blender/Rome/releases/tag/v0.4.0.4

[tmspzz]

@erichoracek any feedback?

[erichoracek]

This build appears to have fixed the issue—thanks again for the responsiveness! Everything now seems to be working beautifully ✨

[tmspzz]

Great! I will make one more change to the Romefile format to align it with the INI file format and then make a stable realease. This will require changing the old Romefile. Sorry for that.

[tmspzz]

@erichoracek v0.4.0.5 with GitHub reference and Romefile ini is out. Please try, beware that the format of the Romefile has changed.

• Section [S3-Bucket] is now called [Cache]
• Section [Cache] must contain a key called S3-Bucket
• Key-Value format is now key = value

Please see Romefile section in README.md