Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@scheme leak across requests #48

Closed
robd opened this issue Mar 24, 2013 · 1 comment
Closed

@scheme leak across requests #48

robd opened this issue Mar 24, 2013 · 1 comment

Comments

@robd
Copy link

robd commented Mar 24, 2013

d0b882a#L0R32, which made scheme an instance variable, seems to allow the scheme to 'leak' across requests.

Consider the following:

  • Request 1 @scheme is set to 'http'
  • Request 2 triggers neither enforce_ssl? or enforce_non_ssl?, @scheme remains as 'http'

Have I missed something here?
@robd
Copy link
Author

robd commented Mar 24, 2013

Oh, ignore me, I see @scheme gets assigned nil in this case. Sorry for noise.

@robd robd closed this as completed Mar 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robd