Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates? #87

Closed
adsick opened this issue Nov 20, 2021 · 6 comments
Closed

updates? #87

adsick opened this issue Nov 20, 2021 · 6 comments

Comments

@adsick
Copy link

adsick commented Nov 20, 2021

mini-redis is used for learning async programming in Rust, but I feel like it needs to be updated.
@adsick
Copy link
Author

adsick commented Nov 20, 2021

consider this for example: https://github.com/tokio-rs/mini-redis/blob/tutorial/src/connection.rs#L27-L30

@adsick
Copy link
Author

adsick commented Nov 20, 2021

also I did not found any CHANGELOG of Tokio, so can't determine if that was fixed.

@Darksonn
Copy link
Collaborator

The particular thing that the comment is referring to is tokio#2428, which we ended up deciding against. You can find the changelog here.

@adsick
Copy link
Author

adsick commented Nov 21, 2021

Thanks

@adsick adsick closed this as completed Nov 21, 2021
@adsick
Copy link
Author

adsick commented Nov 30, 2021

Thanks

@Darksonn
Copy link
Collaborator

Darksonn commented Dec 1, 2021

Hm, it seems like we have both a tutorial and a master branch, and I don't remember why. This has been fixed on the master branch a while ago. Will investigate...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Darksonn @adsick