Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Doc tests fail with Timestamp and compiling well known types #621

Closed
LucioFranco opened this issue Apr 8, 2022 · 5 comments
Closed

build: Doc tests fail with Timestamp and compiling well known types #621

LucioFranco opened this issue Apr 8, 2022 · 5 comments

Comments

@LucioFranco
Copy link
Member

Related issue hyperium/tonic#967
@LucioFranco
Copy link
Member Author

Reproduction https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=5bae9f522bcb6941ccb356289dfeb33f

@LucioFranco LucioFranco mentioned this issue Apr 8, 2022
Closed
@LucioFranco
Copy link
Member Author

Smaller reproduction https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=c3b61be63d8b9c075a8c122a07fc0dc1

@LucioFranco LucioFranco mentioned this issue Apr 8, 2022
Closed
@LucioFranco
Copy link
Member Author

Actually turns out its a valid code block and I didn't know that markdown supported that syntax. So we will need to find a way to update the code.

@LucioFranco
Copy link
Member Author

Looks like prost already supports this via https://docs.rs/prost-build/latest/prost_build/struct.Config.html#method.disable_comments.

In the future, we may want to consider providing well_known_types that can work around the codeblock issue.

@LucioFranco
Copy link
Member Author

#633 fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LucioFranco