diff --git a/clippy.toml b/clippy.toml index bc44be8361..fcd0eeda24 100644 --- a/clippy.toml +++ b/clippy.toml @@ -1,4 +1,4 @@ -blacklisted-names = [] +disallowed-names = [] cognitive-complexity-threshold = 100 too-many-arguments-threshold = 8 type-complexity-threshold = 375 diff --git a/tracing-subscriber/benches/support/mod.rs b/tracing-subscriber/benches/support/mod.rs index 25e9e7e229..3abaa807aa 100644 --- a/tracing-subscriber/benches/support/mod.rs +++ b/tracing-subscriber/benches/support/mod.rs @@ -33,7 +33,7 @@ impl MultithreadedBench { thread::spawn(move || { let dispatch = this.dispatch.clone(); tracing::dispatcher::with_default(&dispatch, move || { - f(&*this.start); + f(&this.start); this.end.wait(); }) }); diff --git a/tracing-subscriber/src/fmt/format/json.rs b/tracing-subscriber/src/fmt/format/json.rs index c2f4d37553..bf32f7c9a8 100644 --- a/tracing-subscriber/src/fmt/format/json.rs +++ b/tracing-subscriber/src/fmt/format/json.rs @@ -720,7 +720,7 @@ mod test { ); let span = tracing::info_span!("the span", na = tracing::field::Empty); - span.record("na", &"value"); + span.record("na", "value"); let _enter = span.enter(); tracing::info!("an event inside the root span"); diff --git a/tracing-subscriber/src/registry/sharded.rs b/tracing-subscriber/src/registry/sharded.rs index 07c94fccb5..88520a2a66 100644 --- a/tracing-subscriber/src/registry/sharded.rs +++ b/tracing-subscriber/src/registry/sharded.rs @@ -902,7 +902,7 @@ mod tests { drop(span3); - state.assert_closed_in_order(&["child", "parent", "grandparent"]); + state.assert_closed_in_order(["child", "parent", "grandparent"]); }); } } diff --git a/tracing-subscriber/tests/field_filter.rs b/tracing-subscriber/tests/field_filter.rs index f14a0626d3..385d024f65 100644 --- a/tracing-subscriber/tests/field_filter.rs +++ b/tracing-subscriber/tests/field_filter.rs @@ -103,7 +103,7 @@ fn record_after_created() { tracing::debug!("i'm disabled!"); }); - span.record("enabled", &true); + span.record("enabled", true); span.in_scope(|| { tracing::debug!("i'm enabled!"); }); diff --git a/tracing/src/span.rs b/tracing/src/span.rs index 58822f4d9b..7be56abdf5 100644 --- a/tracing/src/span.rs +++ b/tracing/src/span.rs @@ -1617,7 +1617,7 @@ mod test { #[test] fn test_record_backwards_compat() { - Span::current().record("some-key", &"some text"); - Span::current().record("some-key", &false); + Span::current().record("some-key", "some text"); + Span::current().record("some-key", false); } } diff --git a/tracing/tests/span.rs b/tracing/tests/span.rs index 4ed6500235..b148f7317b 100644 --- a/tracing/tests/span.rs +++ b/tracing/tests/span.rs @@ -563,7 +563,7 @@ fn record_new_value_for_field() { with_default(subscriber, || { let span = tracing::span!(Level::TRACE, "foo", bar = 5, baz = false); - span.record("baz", &true); + span.record("baz", true); span.in_scope(|| {}) }); @@ -598,8 +598,8 @@ fn record_new_values_for_fields() { with_default(subscriber, || { let span = tracing::span!(Level::TRACE, "foo", bar = 4, baz = false); - span.record("bar", &5); - span.record("baz", &true); + span.record("bar", 5); + span.record("baz", true); span.in_scope(|| {}) });