Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscriber: Revisit env filter directives with targets and spans #367

Open
davidbarsky opened this issue Sep 27, 2019 · 0 comments
Open

subscriber: Revisit env filter directives with targets and spans #367

davidbarsky opened this issue Sep 27, 2019 · 0 comments
Labels
crate/subscriber Related to the `tracing-subscriber` crate meta/breaking This is a breaking change, and should wait until the next breaking release.
Milestone
tracing-subscribe...

Comments

@davidbarsky
Copy link
Member

Right now, a span filter will turn on everything inside that span, regardless of target. This is a possibly confusing user-experience.

Right now, the target is used to match the span for which the level is set for, but it probably should be changed to set a level for everything with that target, inside the span.
@hawkw hawkw changed the title [Revisit Design Decision] subscriber: Revisit env filter directives with targets and spans Sep 27, 2019
@hawkw hawkw added the crate/subscriber Related to the `tracing-subscriber` crate label Oct 1, 2019
@hawkw hawkw mentioned this issue Oct 3, 2019
Closed
@LucioFranco LucioFranco mentioned this issue Oct 4, 2019
Open
@hawkw hawkw added this to the tracing-subscriber 0.3 milestone Mar 11, 2020
@hawkw hawkw added the meta/breaking This is a breaking change, and should wait until the next breaking release. label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crate/subscriber Related to the `tracing-subscriber` crate meta/breaking This is a breaking change, and should wait until the next breaking release.
Projects
None yet
Milestone
tracing-subscriber 0.4
Development

No branches or pull requests
2 participants
@davidbarsky @hawkw