-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It takes a while to dump a 161Mb file from ADFS. #13
Comments
Thanks for the report! (I assume I must admit, I never tried adf_extract with anything larger than an ADFS L disk, so I'm relieved to hear it works at all.) I agree that it should be quicker than "minutes"! Are these disk image files available for download anywhere? The actual reading of the image hopefully won't be the problem, as that happens up front as a single read - but who knows. But I can see a couple of possible things now I"m looking at the code suspiciously. |
The source files are on archive.org, but they're huge. |
I unpacked it using chdman:
THis produced a 230,281,216 byte file, sha1sum 6da2bb8b2ccf686d0ffeda9b9b72c0c5b3fac17e. Running it through adf_extract, it seems this is too short:
So the file I've tidied things up a bit so adf_extract can deal with this a bit better: there's a new |
Hey, this is amazing. Thanks for the fixes and the speed of working on them. The reason the file size is smaller is because the extractor only extends the file if there are new sectors extracted and if there is no data (eg. Audio is being stored) then it doesn't write more to the file - the size allows it to seek to these parts of the disk though so you can still access photos and video. I used |
BTW, I had to edit all the .inf files to add $. to the front before they'd work with beeblink.. I tried loading the !BOOT on B2 and it got very upset. I didn't expect that, but of course it's lacking the SCSI and AIV roms |
Yes, the .inf files produced by adf_extract aren't currently suitable for use with BeebLink directly - it's set up for some future BeebLink expansion that'll deal with hierarchical file structure. (This is something that's been on my todo list for years, and I will get round to it eventually.) I think they might also work with Disk Image Manager. I don't know anything about the BBC's SCSI interface yet, though it's next on my list for b2, so I'll watch with interest! The BeebLink ROM does have an OSWORD call for making server requests (https://github.com/tom-seddon/beeblink/blob/master/docs/tech.md#new-osword-call), though all the request types supported by the server are currently file-based. It could be extended with some block-based mechanism (fetching sectors from some set of specific disk image files) if that'd simplify things though. |
Perhaps use mmap? I'm dumping the Domesday discs to use with beeblink. I don't think I actually need this giant file but honestly a modern PC with SSD should be dumping this in seconds, not minutes. The ADF is stored on a network share, so it could be latency...
The text was updated successfully, but these errors were encountered: