-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI appears to be failing on all branches on rust v1.51 #261
Comments
Time has a frustrating MSRV policy summarised as "the last six months", given Rust's release cadence basically means the last 4 point releases. We can consider pinning time but you might be right and moving to 1.56 could be easier. |
Time seems to be running away from us... |
Yeah that's my concern with continually updating it like this. We can probably pin the version without any ill effect if we don't export the type but I'd have to go and check if we leak it anywhere. |
Closing as we dropped the mandatory test on old Rust versions and will just deal with issues as they arise. |
CI appears to be failing on all branches when using rust version 1.51
example: https://github.com/tomaka/rouille/runs/6828755515?check_suite_focus=true
this is the issue rust-lang/rust#81110
it is fixed in 1.52, however
1.52 requires cargo-features = ["edition2021"]
and this feature is not stabilised until 1.56.
One solution is to drop support for 1.51 and make 1.56 the minimum supported version. #260
However this needs to be considered for the impact it will have on projects utilising the framework.
Since its failing to compile
time
I don't think there is anything else that can be done.The text was updated successfully, but these errors were encountered: