make 'drag to seek' diff from 'click to seek'

[hooke007]

It could be a catastrophy of performance if users seek by dragging. The condition would became worse when combining it with thumbnail preview.

We may need to make 'drag to seek' diff from 'click to seek', just like what osc did.
https://github.com/mpv-player/mpv/blob/cc65b3892d89ae35d31067fba285ab20716a1aee/player/lua/osc.lua#L2027-L2041

• Current

Note: I am using a simplified thumbfast.lua which performs much better than original version.
Considering most users doesn't have the powerful CPU, they will feel obvious lagging.

slow.mp4

• Try fastseek

fast.mp4

[tomasklaen]

I've tried it just today, and although this is fine on longer videos, drag seeking on shorter ones makes timeline look like it's having a seizure. The handle is jumping all over the place. This becomes even more of an issue on videos with big keyframe distances.

I'll add an option for it, but it'll be disabled by default.

[christoph-heinrich]

We could do keyframe seeks while dragging around, and then when the user stops (releases mouse button or stops moving for long enough) we do an exact seek. That way we don't need another option.

[christoph-heinrich]

Note: I am using a simplified thumbfast.lua which performs much better than original version.

Please share your improvments with the rest of us by making a PR 🙏

[hooke007]

I do not think it will be received. For I cleaned all unnecessary (I think) process of encoding such as rotate par pad ...

[christoph-heinrich]

Isn't vf required for scaling down?

[hooke007]

Ah, sry I mean only scale was left in vf

[hooke007]

Comparing with the encoding step, we waste much too performance on decoding. The thumbpreview feature is almost unavailable when watching 4k-HDR sources for most users.
And I checked the recent commits, po5/thumbfast@eb21b2e seems to try to improve it.
The non-linear or non-fixed frequency of requests may greatly reduce the pressure of decoding.

[NormTurtle]

sir, lease 🙏 share how u have that bufffring ROTATE logo in middle? 🥺 @hooke007

[hooke007]

It's master branch.

[NormTurtle]

It's master branch.

huh?

[hooke007]

https://github.com/tomasklaen/uosc/tree/main/scripts