-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Create to show the original exception traceback #3508
Conversation
I wonder if we could take advantage of the nested exceptions with Python 3.x |
Yes, my first thought that using |
There might be an interesting opportunity in improve exception messages like this in some places to include the original. Similar case in #3490. |
Yup, looks good! |
Leaving this open until have time to also address #3490, and also review if there are any other similar cases we could be addressing. Pull requests addressing this throughout from anyone else also most welcome if you happen to get to it before I do. |
On second thoughts may as well merge this now. |
Woo! Thank you @tomchristie, you don't know how happy this makes me. |
😄 Most welcome - appreciate the input! |
This small pull request includes the original exception traceback in the re-raised TypeError, re: #3503. If there is an error somewhere during the create operation the error message turns from:
To the much more helpful: