-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can you migrate this to Libraries 2.0 #10
Comments
#12 Should have fixed it. |
Nope, libraries 2.0 requires a different file structure too (as commented on #12) |
I've filed PR for this Please merge and reupload to Particle Library repository |
any progress on resolving this? |
Can we fork this and do what's necessary to get this into Particle's 2.0 format? The DS18B20 library (in particle) is lacking many features of this library. |
Yeah definitely, just fork it and make the changes you need :)
… On 8 Apr 2019, at 20:33, GregSawin ***@***.***> wrote:
Can we fork this and do what's necessary to get this into Particle's 2.0 format? The DS18B20 library (in particle) is lacking many features of this library.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@ScruffR did you want to do that? |
Particle needs to take ownership of that library on their side to allow anybody else to upload an updated version. The issue with "stale"/abandoned libraries is a reoccuring topic when we talk to Particle 😉
Can you list some? |
Alarms is the big one that's missing but I don't personally use that. The main feature I like is that you can request the temp from all sensors at once. This can either block until all are ready or return immediately and let you query for the status. After that you can quickly grab the temp from each sensor by index. You can also get a total device count as well as get an address by index. While neither library does this, I think the library should handle the temp validation and automatically retry as needed. The relative flakiness of the dallas sensors seems to be a real pain point for people and neither library provides a good out of the box way to get and confirm a good read. In other words I'd like to be able to suggest a library and have the example work robustly as is and not have to tell them how to alter the code to deal with the bad reads. Perhaps the library could internally track bad reads and provide a function to check this data to help identify wiring issues or a failing sensor. So personally I'm using a mix of both libraries as well as custom versions I've created from them. I'd like to consolidate all my programs to use the same library so I've recently started looking into the pros & cons of each. If I can get close enough with a standard Web IDE compatible library then I'd use that and likely submit my enhancements via github PR so everyone can benefit. |
Thanks @ScruffR I've added this to the list and we'll work on getting it ported over. |
Currently this lib does not build with 2.0 projects anymore due to the
../
includes.If you can't or don't want to, can we take ownership of this library for Particle Elite?
The text was updated successfully, but these errors were encountered: