Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Try webpack/babel instead of rollup/buble #14

Open
tomwayson opened this issue Mar 20, 2017 · 2 comments
Open

Try webpack/babel instead of rollup/buble #14

tomwayson opened this issue Mar 20, 2017 · 2 comments

Comments

@tomwayson
Copy link
Owner

tomwayson commented Mar 20, 2017

Rollup/buble make it hard to test in a browser (i.e. w/ Karma vs tests that execute in node like w/ Ava). The crux of the problem is this jlmakes/karma-rollup-preprocessor#17

For that reason, I started running the tests off the transpiled build output. That works, but it requires adding concurrently to run builds on changes and run karma in watch mode. A bigger problem is that the tests themselves are ES6, so they have to be transpiled too, and there's not a karma preprocessor for buble, so I'm using the one for babel (see #12).

Ultimately the target consumers of this library are ember addons, which use babel to transpile, so might as well try to use the same preset, etc here.

So, at a high level:

  1. replace rollup/buble w/ webpack/babel and verify that we can get a reasonable build size
  2. try running tests w/ https://github.com/webpack-contrib/karma-webpack
@tomwayson
Copy link
Owner Author

@tomwayson
Copy link
Owner Author

Note looks like the latest ember-cli-babel is now using babel-preset-env

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant