Fix property attribute detection #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
approved these changes
Jun 27, 2019
MarcoRossignoli
added
enhancement
MarcoRossignoli
changed the title
tonerdo
approved these changes
Jul 3, 2019
|
Question: Can someone confirm whether this resolves #81 and if so, which version of coverlet this bug fix is in/will be in? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized my initial work on #233 and #232 overlooked custom attributes on properties and checking them against each of the generated methods. This resolves that with a few updated tests and may achieve the desired result for #81 if you add
CompilerGeneratedto the list of excluded attributes.I didn't create a new issue for this per the contribution guidelines since it was technically related to an existing one, but let me know if you want one there.